feat: Add countMessages and listMessages operations#25
feat: Add countMessages and listMessages operations#25sureshg wants to merge 2 commits intofunfix:mainfrom
Conversation
|
@alexandru Hi, could you check if this makes sense? |
|
@sureshg thanks, but I'm not interested in adding this functionality. For one, even though the project's aim is to model queues based on RDBMSs, the interface is generic enough that it could use NoSQL, and we can take some liberties with the implementation. For example, it could do sharding, or fallbacks (e.g., from a central RDBMS to a local one in case the central server is offline). Note, Also, being a maintainer for some time, and being friends with other maintainers of popular libraries, I'm wary that the effort required to do drive-by PRs has gone down, this increasing the review burden for maintainers. So I think we need a netiquette to first ask if certain features are desired, before submitting the PR (method signatures in this case would've been enough for me to say no 🙂). |
Thanks!
Sure, totally understand and apologies for that. That was actually my intention too.. I started with the feature request in #24, but then got a bit carried away since the implementation felt small enough to just go ahead with (of course with AI help, especially for Scala part, doc, testing etc). Sorry for the inconvenience! |
Fixes #24